RESOLVED FIXED 76982
File extension for webp files is .webp 
https://bugs.webkit.org/show_bug.cgi?id=76982
Summary File extension for webp files is .webp
noel gordon
Reported 2012-01-24 22:41:45 PST
File extension for webp files is .webp
Attachments
Patch (1.47 KB, patch)
2012-01-24 22:42 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2012-01-24 22:42:50 PST
Created attachment 123886 [details] Patch
Adam Barth
Comment 2 2012-01-24 23:28:09 PST
Comment on attachment 123886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123886&action=review > Source/WebCore/ChangeLog:8 > + No new tests. No change in behavior. This doesn't change behavior? Is this change observable somehow?
Adam Barth
Comment 3 2012-01-24 23:29:09 PST
Comment on attachment 123886 [details] Patch I'm marking this r+ in case there isn't a way to test this (referring to our earlier conversation about timezones causing 24hr latency on questions). However, if there is a way to test this change, we should include a test. That might require digging a bit to understand what this function is used for.
noel gordon
Comment 4 2012-01-24 23:42:17 PST
> This doesn't change behavior? Is this change observable somehow? Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change.
Adam Barth
Comment 5 2012-01-24 23:43:45 PST
> Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change. We'll need to look at the callers of this function to understand what they're using this information for and craft a test that exercises them. If no one uses this information for anything observable, we should remove the function.
noel gordon
Comment 6 2012-01-25 14:33:02 PST
Thanks Adam. I'm OOO today and will dig around as you suggested Friday my time.
noel gordon
Comment 7 2012-01-26 14:54:20 PST
filenameExtension() was added to BitmapImage{.h.cpp} in http://trac.webkit.org/changeset/39185 to resolve bug 20685. A manual test was added at that time. I can't access the bug, the code change hints at some security issue with drag drop.
Adam Barth
Comment 8 2012-01-26 15:00:33 PST
We can problem unprotect that bug as this point, but this isn't really testable in an automated way. Thanks for tracking it down.
WebKit Review Bot
Comment 9 2012-01-26 15:44:37 PST
Comment on attachment 123886 [details] Patch Clearing flags on attachment: 123886 Committed r106055: <http://trac.webkit.org/changeset/106055>
WebKit Review Bot
Comment 10 2012-01-26 15:44:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.