File extension for webp files is .webp
Created attachment 123886 [details] Patch
Comment on attachment 123886 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123886&action=review > Source/WebCore/ChangeLog:8 > + No new tests. No change in behavior. This doesn't change behavior? Is this change observable somehow?
Comment on attachment 123886 [details] Patch I'm marking this r+ in case there isn't a way to test this (referring to our earlier conversation about timezones causing 24hr latency on questions). However, if there is a way to test this change, we should include a test. That might require digging a bit to understand what this function is used for.
> This doesn't change behavior? Is this change observable somehow? Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change.
> Ran layout tests locally on mac, no changes observed. Not sure how we'd observe this change. We'll need to look at the callers of this function to understand what they're using this information for and craft a test that exercises them. If no one uses this information for anything observable, we should remove the function.
Thanks Adam. I'm OOO today and will dig around as you suggested Friday my time.
filenameExtension() was added to BitmapImage{.h.cpp} in http://trac.webkit.org/changeset/39185 to resolve bug 20685. A manual test was added at that time. I can't access the bug, the code change hints at some security issue with drag drop.
We can problem unprotect that bug as this point, but this isn't really testable in an automated way. Thanks for tracking it down.
Comment on attachment 123886 [details] Patch Clearing flags on attachment: 123886 Committed r106055: <http://trac.webkit.org/changeset/106055>
All reviewed patches have been landed. Closing bug.