Bug 76979 - webkit-unit-test bustage doesn't turn the EWS red
Summary: webkit-unit-test bustage doesn't turn the EWS red
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 21:30 PST by WebKit Review Bot
Modified: 2012-06-19 00:38 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-01-24 21:30:54 PST
webkit-unit-test bustage doesn't turn the EWS red
Requested by abarth on #webkit.
Comment 1 Adam Barth 2012-01-25 02:14:33 PST
I understand what's causing this issue.  When the webkit-unit-tests fail, we think that run-webkit-tests crashed and that the results are unreliable.  Therefore, we retry the patch rather than failing it.
Comment 2 Adam Barth 2012-01-25 02:16:07 PST
Right now there's a problem that the unit tests are red and therefore are blocking the EWS from processing patches.  I'm going to disable them temporarily.
Comment 3 Adam Barth 2012-01-25 02:17:02 PST
The solution to both problems is to understand what set of unit tests failed on a given run rather than just a binary "did pass all tests".
Comment 4 Adam Barth 2012-01-25 02:18:50 PST
Disabled in http://trac.webkit.org/changeset/105857.
Comment 5 James Robinson 2012-01-25 02:24:41 PST
Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place.
Comment 6 Adam Barth 2012-01-25 02:28:43 PST
> Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place.

We can do that as well.  This is a systemic problem.  The unit tests aren't properly integrated with the EWS.
Comment 7 Adam Barth 2012-06-19 00:38:20 PDT
jamesr fixenated this bug.