webkit-unit-test bustage doesn't turn the EWS red
Requested by abarth on #webkit.
I understand what's causing this issue. When the webkit-unit-tests fail, we think that run-webkit-tests crashed and that the results are unreliable. Therefore, we retry the patch rather than failing it.
Right now there's a problem that the unit tests are red and therefore are blocking the EWS from processing patches. I'm going to disable them temporarily.
The solution to both problems is to understand what set of unit tests failed on a given run rather than just a binary "did pass all tests".
Disabled in http://trac.webkit.org/changeset/105857.
Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place.
> Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place.
We can do that as well. This is a systemic problem. The unit tests aren't properly integrated with the EWS.
jamesr fixenated this bug.