RESOLVED FIXED Bug 76979
webkit-unit-test bustage doesn't turn the EWS red 
https://bugs.webkit.org/show_bug.cgi?id=76979
Summary webkit-unit-test bustage doesn't turn the EWS red
WebKit Review Bot
Reported 2012-01-24 21:30:54 PST
webkit-unit-test bustage doesn't turn the EWS red Requested by abarth on #webkit.
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-25 02:14:33 PST
I understand what's causing this issue. When the webkit-unit-tests fail, we think that run-webkit-tests crashed and that the results are unreliable. Therefore, we retry the patch rather than failing it.
Adam Barth
Comment 2 2012-01-25 02:16:07 PST
Right now there's a problem that the unit tests are red and therefore are blocking the EWS from processing patches. I'm going to disable them temporarily.
Adam Barth
Comment 3 2012-01-25 02:17:02 PST
The solution to both problems is to understand what set of unit tests failed on a given run rather than just a binary "did pass all tests".
Adam Barth
Comment 4 2012-01-25 02:18:50 PST
Disabled in http://trac.webkit.org/changeset/105857.
James Robinson
Comment 5 2012-01-25 02:24:41 PST
Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place.
Adam Barth
Comment 6 2012-01-25 02:28:43 PST
> Why not revert the patch that broke the unit tests instead? We shouldn't have broken tests in the first place. We can do that as well. This is a systemic problem. The unit tests aren't properly integrated with the EWS.
Adam Barth
Comment 7 2012-06-19 00:38:20 PDT
jamesr fixenated this bug.
Note You need to log in before you can comment on or make changes to this bug.