Bug 76969 - Make DFG update topCallFrame
Summary: Make DFG update topCallFrame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 17:53 PST by Oliver Hunt
Modified: 2012-01-25 11:44 PST (History)
0 users

See Also:

Attachments
Patch (24.15 KB, patch)
2012-01-24 17:56 PST, Oliver Hunt 		no flags Details | Formatted Diff | Diff
Patch (24.08 KB, patch)
2012-01-24 17:57 PST, Oliver Hunt 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2012-01-24 17:53:10 PST 
Make DFG update topCallFrame
Comment 1 Oliver Hunt 2012-01-24 17:56:09 PST 
Created attachment 123861 [details]
Patch
Comment 2 Oliver Hunt 2012-01-24 17:57:48 PST 
Created attachment 123862 [details]
Patch
Comment 3 Filip Pizlo 2012-01-25 11:40:32 PST 
Comment on attachment 123862 [details]
Patch

r=me.
Comment 4 Oliver Hunt 2012-01-25 11:43:41 PST 
Committed r105905: <http://trac.webkit.org/changeset/105905>
Comment 5 Geoffrey Garen 2012-01-25 11:44:43 PST 
Comment on attachment 123862 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123862&action=review

Can you post performance results?

> Source/JavaScriptCore/interpreter/Interpreter.h:91
> +    class NativeCallFrameTracer {
> +    public:
> +        ALWAYS_INLINE NativeCallFrameTracer(JSGlobalData* global, CallFrame* callFrame)
> +        {
> +            ASSERT(global);
> +            ASSERT(callFrame);
> +            global->topCallFrame = callFrame;
> +        }
> +    };

Is it OK that we don't reset topCallFrame on destruction? When do we need to reset it, and when can we skip that step?

I don't think the words "native" and "tracer" are clear enough to distinguish NativeCallFrameTracer from TopCallFrameSetter. Answers to the above questions can provide us with a better name.