Bug 76960 - Initializing the browser property of the Bugzilla class takes too long
Summary: Initializing the browser property of the Bugzilla class takes too long
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 16:35 PST by Ojan Vafai
Modified: 2012-01-24 18:14 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.14 KB, patch)
2012-01-24 16:36 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-24 16:35:44 PST 
Initializing the browser property of the Bugzilla class takes too long
Comment 1 Ojan Vafai 2012-01-24 16:36:39 PST 
Created attachment 123839 [details]
Patch
Comment 2 Adam Barth 2012-01-24 16:39:34 PST 
Comment on attachment 123839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123839&action=review

> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270
> +    def _get_browser(self):

Can we just make this memoized?
Comment 3 Ojan Vafai 2012-01-24 16:45:06 PST 
(In reply to comment #2)
> (From update of attachment 123839 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123839&action=review
> 
> > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270
> > +    def _get_browser(self):
> 
> Can we just make this memoized?

No, the tests rely on being able to set .browser. So, we need a setter, which means we can't.
Comment 4 WebKit Review Bot 2012-01-24 17:44:23 PST 
Comment on attachment 123839 [details]
Patch

Rejecting attachment 123839 [details] from commit-queue.

New failing tests:
media/audio-garbage-collect.html
Full output: http://queues.webkit.org/results/11342147
Comment 5 WebKit Review Bot 2012-01-24 18:14:08 PST 
Comment on attachment 123839 [details]
Patch

Clearing flags on attachment: 123839

Committed r105842: <http://trac.webkit.org/changeset/105842>
Comment 6 WebKit Review Bot 2012-01-24 18:14:13 PST 
All reviewed patches have been landed.  Closing bug.