WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76960
Initializing the browser property of the Bugzilla class takes too long
https://bugs.webkit.org/show_bug.cgi?id=76960
Summary
Initializing the browser property of the Bugzilla class takes too long
Ojan Vafai
Reported
2012-01-24 16:35:44 PST
Initializing the browser property of the Bugzilla class takes too long
Attachments
Patch
(2.14 KB, patch)
2012-01-24 16:36 PST
,
Ojan Vafai
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ojan Vafai
Comment 1
2012-01-24 16:36:39 PST
Created
attachment 123839
[details]
Patch
Adam Barth
Comment 2
2012-01-24 16:39:34 PST
Comment on
attachment 123839
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=123839&action=review
> Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270 > + def _get_browser(self):
Can we just make this memoized?
Ojan Vafai
Comment 3
2012-01-24 16:45:06 PST
(In reply to
comment #2
)
> (From update of
attachment 123839
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=123839&action=review
> > > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:270 > > + def _get_browser(self): > > Can we just make this memoized?
No, the tests rely on being able to set .browser. So, we need a setter, which means we can't.
WebKit Review Bot
Comment 4
2012-01-24 17:44:23 PST
Comment on
attachment 123839
[details]
Patch Rejecting
attachment 123839
[details]
from commit-queue. New failing tests: media/audio-garbage-collect.html Full output:
http://queues.webkit.org/results/11342147
WebKit Review Bot
Comment 5
2012-01-24 18:14:08 PST
Comment on
attachment 123839
[details]
Patch Clearing flags on attachment: 123839 Committed
r105842
: <
http://trac.webkit.org/changeset/105842
>
WebKit Review Bot
Comment 6
2012-01-24 18:14:13 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug