RESOLVED CONFIGURATION CHANGED 76950
commit queue false negatives: invalid reviewer 
https://bugs.webkit.org/show_bug.cgi?id=76950
Summary commit queue false negatives: invalid reviewer
Noam Rosenthal
Reported 2012-01-24 15:17:01 PST
Patch has a valid reviewer and a valid changelog entry, yet it's rejected by cq with an "Invalid Reviewer" error. See https://bugs.webkit.org/show_bug.cgi?id=76660#c14
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-01-24 16:14:33 PST
Looks like the commit-queue is having trouble parsing the ChangeLog in your patch. It's probably best to have a committer land your patch manually while we figure out this issue.
Noam Rosenthal
Comment 2 2012-01-24 16:18:59 PST
> Looks like the commit-queue is having trouble parsing the ChangeLog in your patch. It's probably best to have a committer land your patch manually while we figure out this issue. Thanks, I'm already working on manually landing it, just thought it would be good to report the issue :)
Adam Barth
Comment 3 2012-01-24 16:57:54 PST
> Thanks, I'm already working on manually landing it, just thought it would be good to report the issue :) Yes, thanks for reporting it. My shift watching the bots is over after today, and I've got a couple things queued up, but I should be able to look at this issue this week.
Noam Rosenthal
Comment 4 2012-01-24 17:08:33 PST
I think I found the problem, there was an extra space in the beginning of the Changelog... If this fixes the problem, should I close this bug or should we try to make the error message more descriptive?
Adam Barth
Comment 5 2012-01-24 17:20:29 PST
We should produce a better error message. The message you got was a result of the tool crashing (i.e., it was just a nonsense stack trace).
Eric Seidel (no email)
Comment 6 2012-01-24 18:11:33 PST
That happens way too often. I've definitely seen at least 3 cases of leading spaces in the ChangeLog causing us to bail confusingly. I wonder what people are doing to end up with this leading space?
Noam Rosenthal
Comment 7 2012-01-24 19:30:05 PST
(In reply to comment #6) > That happens way too often. I've definitely seen at least 3 cases of leading spaces in the ChangeLog causing us to bail confusingly. I wonder what people are doing to end up with this leading space? You mean, other than edit the changelog in an editor and press the spacebar by mistake? :)
Ahmad Saleem
Comment 8 2023-07-03 07:25:30 PDT
'ChangeLog' file is gone with move to GitHub, we can close this bug now. @ap - any thoughts?
Alexey Proskuryakov
Comment 9 2023-07-03 09:00:34 PDT
Indeed.
Note You need to log in before you can comment on or make changes to this bug.