Bug 76949 - check-webkit-style warns about ; inside quotation marks for python code.
Summary: check-webkit-style warns about ; inside quotation marks for python code.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 14:55 PST by Ryosuke Niwa
Modified: 2012-01-27 08:53 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-01-24 14:55:06 PST 
check-webkit-style erroneously complains about having multiple statements for the patch on https://bugs.webkit.org/show_bug.cgi?id=76312 due to ; appearing inside single quotation marks.
Comment 1 David Levin 2012-01-24 16:45:13 PST 
Code is here: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py and not too hard for new comers to change/fix as eae@chromium.org just demonstrated.
Comment 2 David Levin 2012-01-27 08:53:09 PST 
Whoops, this is about python code. For that WebKit just uses an external package.

http://pypi.python.org/pypi/pep8

So it can't be fixed inside of WebKit. It would be best to follow up there if you want it fixed. It is referenced here:  Tools/Scripts/webkitpy/thirdparty/__init__.py