Bug 76940 - Change dispatchIntent API to pure virtual in FrameLoaderClient.
Summary: Change dispatchIntent API to pure virtual in FrameLoaderClient.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Greg Billock
URL:
Keywords:
Depends on:
Blocks: 75123
  Show dependency tree / graph
 
Reported: 2012-01-24 13:24 PST by Greg Billock
Modified: 2012-01-24 14:36 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2012-01-24 13:26 PST, Greg Billock 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Billock 2012-01-24 13:24:57 PST 
Change dispatchIntent API to pure virtual in FrameLoaderClient.
Comment 1 Greg Billock 2012-01-24 13:26:31 PST 
Created attachment 123792 [details]
Patch
Comment 2 Adam Barth 2012-01-24 13:28:17 PST 
Comment on attachment 123792 [details]
Patch

Ok.  I'm not sure I fully understand why, but this change is fine.
Comment 3 Greg Billock 2012-01-24 13:39:04 PST 
(In reply to comment #2)
> (From update of attachment 123792 [details])
> Ok.  I'm not sure I fully understand why, but this change is fine.

It looks like all our other compilers have no problems with this. The Windows error message is that PassRefPtr.h needs the WebCore::IntentRequest object to be fully defined in order to do ->deref() on the type. As a guess, the compiler is trying to do codegen for the empty method when others don't need to? (The errors are from includes in Document.cpp and DOMImplementation.cpp, which don't call that method. I don't develop on Windows, so I'm depending on others' expertise here...
Comment 4 WebKit Review Bot 2012-01-24 14:36:15 PST 
Comment on attachment 123792 [details]
Patch

Clearing flags on attachment: 123792

Committed r105812: <http://trac.webkit.org/changeset/105812>
Comment 5 WebKit Review Bot 2012-01-24 14:36:20 PST 
All reviewed patches have been landed.  Closing bug.