Bug 76937 – [Chromium] Expose perTilePainting setting through WebLayerTreeView::Settings interface.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[David Reveman]

Per-tile painting feature is currently not exposed in WebLayerTreeView::Settings, which prevents it from being used by the browser compositor.

[Antoine Labour]

https://bugs.webkit.org/show_bug.cgi?id=75591 exposes it, but it hasn't landed yet.
Also, be aware that we can't use it in the browser until http://code.google.com/p/chromium/issues/detail?id=103648 is fixed.

[David Reveman]

Created attachment 123816 [details]
Patch

[Antoine Labour]

Comment on attachment 123816 [details]
Patch

LGTM

[David Reveman]

(In reply to comment #1)
> https://bugs.webkit.org/show_bug.cgi?id=75591 exposes it, but it hasn't landed yet.

OK, I attached a simple patch to this bug in case we want to land something prior to that patch.

> Also, be aware that we can't use it in the browser until http://code.google.com/p/chromium/issues/detail?id=103648 is fixed.

[David Reveman]

for the chromium side: https://chromiumcodereview.appspot.com/9297006

[David Reveman]

Created attachment 126857 [details]
Patch

Rebase

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[David Reveman]

Created attachment 126904 [details]
Patch

[David Reveman]

Created attachment 126974 [details]
Patch

Rebase

[WebKit Review Bot]

Attachment 126974 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit']" exit_code: 9

Updating OpenSource
First, rewinding head to replay your work on top of it...
Applying: [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
Using index info to reconstruct a base tree...
<stdin>:1578: trailing whitespace.
        
<stdin>:1647: trailing whitespace.
    
<stdin>:1657: trailing whitespace.
    
<stdin>:1672: trailing whitespace.
        return 0;        
<stdin>:1674: trailing whitespace.
    
warning: squelched 7 whitespace errors
warning: 12 lines add whitespace errors.
Falling back to patching base and 3-way merge...
warning: too many files (created: 168776 deleted: 3), skipping inexact rename detection
Auto-merging LayoutTests/ChangeLog
CONFLICT (content): Merge conflict in LayoutTests/ChangeLog
Auto-merging Source/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Auto-merging Source/WebKit2/ChangeLog
CONFLICT (content): Merge conflict in Source/WebKit2/ChangeLog
Auto-merging Tools/ChangeLog
CONFLICT (content): Merge conflict in Tools/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets

When you have resolved this problem run "git rebase --continue".
If you would prefer to skip this patch, instead run "git rebase --skip".
To restore the original branch and stop rebasing run "git rebase --abort".

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.


If any of these errors are false positives, please file a bug against check-webkit-style.

[James Robinson]

Comment on attachment 126974 [details]
Patch

Looks fine, R=me

[WebKit Review Bot]

Comment on attachment 126974 [details]
Patch

Clearing flags on attachment: 126974

Committed r107722: <http://trac.webkit.org/changeset/107722>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.