Bug 76928 - Accelerated drawing should force compositing mode
Summary: Accelerated drawing should force compositing mode
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
Keywords: InRadar
Depends on:
Reported: 2012-01-24 11:26 PST by Beth Dakin
Modified: 2012-01-24 15:21 PST (History)
1 user (show)

See Also:

Patch (2.62 KB, patch)
2012-01-24 11:29 PST, Beth Dakin
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-01-24 11:26:57 PST
Accelerated drawing should force compositing mode. Patch forthcoming.

Comment 1 Beth Dakin 2012-01-24 11:29:05 PST
Created attachment 123776 [details]
Comment 2 Simon Fraser (smfr) 2012-01-24 13:56:23 PST
Comment on attachment 123776 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=123776&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1856
> +    if (settings->acceleratedDrawingEnabled())
> +        settings->setForceCompositingMode(LayerTreeHost::supportsAcceleratedCompositing());
> +    else
> +        settings->setForceCompositingMode(store.getBoolValueForKey(WebPreferencesKey::forceCompositingModeKey()) && LayerTreeHost::supportsAcceleratedCompositing());

This should probably be #if PLATFORM(MAC), and I think it deserves a comment or reference to a radar.
Comment 3 Beth Dakin 2012-01-24 14:11:11 PST
Thanks Simon! I made it Mac-only, and I added a comment as well. Committed change: http://trac.webkit.org/changeset/105806