Bug 76926 - CodeGeneratorCPP.pm should overwrite the output .h/.cpp only if the bytes differ
Summary: CodeGeneratorCPP.pm should overwrite the output .h/.cpp only if the bytes differ
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 76836
  Show dependency treegraph
 
Reported: 2012-01-24 10:54 PST by Kentaro Hara
Modified: 2012-01-24 14:10 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.73 KB, patch)
2012-01-24 11:00 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-24 10:54:56 PST
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

In this bug, we make a change on CodeGeneratorCPP.pm so that it overwrites the output .h/.cpp only if the bytes differ.
Comment 1 Kentaro Hara 2012-01-24 11:00:27 PST
Created attachment 123772 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-24 12:32:08 PST
Comment on attachment 123772 [details]
Patch

Attachment 123772 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11242291

New failing tests:
media/audio-garbage-collect.html
Comment 3 WebKit Review Bot 2012-01-24 14:10:01 PST
Comment on attachment 123772 [details]
Patch

Clearing flags on attachment: 123772

Committed r105805: <http://trac.webkit.org/changeset/105805>
Comment 4 WebKit Review Bot 2012-01-24 14:10:06 PST
All reviewed patches have been landed.  Closing bug.