Bug 76922 - CodeGeneratorJS.pm should overwrite the output .h/.cpp only if the bytes differ
Summary: CodeGeneratorJS.pm should overwrite the output .h/.cpp only if the bytes differ
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 76836
  Show dependency tree / graph
 
Reported: 2012-01-24 09:51 PST by Kentaro Hara
Modified: 2012-01-24 14:24 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2012-01-24 10:01 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-24 09:51:38 PST 
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

In this bug, we make a change on CodeGeneratorJS.pm so that it overwrites the output .h/.cpp only if the bytes differ.
Comment 1 Kentaro Hara 2012-01-24 10:01:35 PST 
Created attachment 123758 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-24 14:01:03 PST 
Comment on attachment 123758 [details]
Patch

Rejecting attachment 123758 [details] from commit-queue.

New failing tests:
media/audio-garbage-collect.html
Full output: http://queues.webkit.org/results/11177053
Comment 3 WebKit Review Bot 2012-01-24 14:24:17 PST 
Comment on attachment 123758 [details]
Patch

Clearing flags on attachment: 123758

Committed r105809: <http://trac.webkit.org/changeset/105809>
Comment 4 WebKit Review Bot 2012-01-24 14:24:21 PST 
All reviewed patches have been landed.  Closing bug.