WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76919
AudioParamTimeline functions should use doubles for time variables
https://bugs.webkit.org/show_bug.cgi?id=76919
Summary
AudioParamTimeline functions should use doubles for time variables
Raymond Toy
Reported
2012-01-24 09:29:16 PST
Many of the functions in the AudioParamTimeline class take floats for the time variables. They should probably take doubles to minimize round-off issues. See, for example,
bug 76073
and
bug 76659
.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Rogers
Comment 1
2012-02-19 01:07:47 PST
Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.
Raymond Toy
Comment 2
2012-02-21 09:16:20 PST
(In reply to
comment #1
)
> Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.
Do you mean only in the IDL or the IDL in addition to the c++ code? It would be best to use doubles in the c++ code and the IDL.
Raymond Toy
Comment 3
2012-02-21 11:22:02 PST
It would be best to do this after
bug 77666
which adds tests for AudioParam. Then we can see what impact this change will have.
Chris Rogers
Comment 4
2012-12-12 14:35:18 PST
Fixed in:
http://trac.webkit.org/changeset/133365
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug