Bug 76919 - AudioParamTimeline functions should use doubles for time variables
Summary: AudioParamTimeline functions should use doubles for time variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Raymond Toy
URL:
Keywords:
Depends on: 77666
Blocks: 78854 100885
  Show dependency tree / graph
 
Reported: 2012-01-24 09:29 PST by Raymond Toy
Modified: 2012-12-12 14:35 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Raymond Toy 2012-01-24 09:29:16 PST 
Many of the functions in the AudioParamTimeline class take floats for the time variables.  They should probably take doubles to minimize round-off issues.  See, for example, bug 76073 and bug 76659.
Comment 1 Chris Rogers 2012-02-19 01:07:47 PST 
Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.
Comment 2 Raymond Toy 2012-02-21 09:16:20 PST 
(In reply to comment #1)
> Please switch to doubles in the IDL unless this is extremely difficult to reconcile with the math.

Do you mean only in the IDL or the IDL in addition to the c++ code? It would be best to use doubles in the c++ code and the IDL.
Comment 3 Raymond Toy 2012-02-21 11:22:02 PST 
It would be best to do this after bug 77666 which adds tests for AudioParam.  Then we can see what impact this change will have.
Comment 4 Chris Rogers 2012-12-12 14:35:18 PST 
Fixed in:
http://trac.webkit.org/changeset/133365