Bug 76915 - [WK2] [GTK] TestDownloads hitting an assertion in Debug builds
Summary: [WK2] [GTK] TestDownloads hitting an assertion in Debug builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sergio Villar Senin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-24 07:58 PST by Sergio Villar Senin
Modified: 2012-01-24 10:03 PST (History)
2 users (show)

See Also:


Attachments
Patch (1.92 KB, patch)
2012-01-24 08:02 PST, Sergio Villar Senin
mrobinson: review+
mrobinson: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2012-01-24 07:58:54 PST
This is the assertion

ASSERTION FAILED: m_downloadClient (DownloadSoup.cpp:135)
Comment 1 Sergio Villar Senin 2012-01-24 08:02:03 PST
Created attachment 123735 [details]
Patch
Comment 2 Carlos Garcia Campos 2012-01-24 08:11:12 PST
Comment on attachment 123735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review

Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle

> Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145
> -    ASSERT(m_downloadClient);
> +    ASSERT(!m_downloadClient);
>      ASSERT(m_resourceHandle);

This should be !m_resourceHandle, since it's assigned to resourceHandle below
Comment 3 Sergio Villar Senin 2012-01-24 08:13:23 PST
(In reply to comment #2)
> (From update of attachment 123735 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123735&action=review
> 
> Yeah, my fault, sorry, Patch is correct, except the m_resourceHandle in Download::startWithHandle
> 
> > Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp:145
> > -    ASSERT(m_downloadClient);
> > +    ASSERT(!m_downloadClient);
> >      ASSERT(m_resourceHandle);
> 
> This should be !m_resourceHandle, since it's assigned to resourceHandle below

Yeah I overlooked it, I thought the ASSERT was checking the function argument
Comment 4 Martin Robinson 2012-01-24 08:48:20 PST
Comment on attachment 123735 [details]
Patch

Please land with cgarcia's suggested fix.
Comment 5 Sergio Villar Senin 2012-01-24 10:03:39 PST
Committed r105746: <http://trac.webkit.org/changeset/105746>