WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76909
Remove unnecessary baseURL member variable from PluginView
https://bugs.webkit.org/show_bug.cgi?id=76909
Summary
Remove unnecessary baseURL member variable from PluginView
Kaustubh Atrawalkar
Reported
2012-01-24 06:12:32 PST
With reference to earlier bug -
https://bugs.webkit.org/show_bug.cgi?id=62818
, There was a fixme added to remove the unnecessary m_baseURL member variable. Adding bug for the same. This will reduce the PluginView object memory footprint. Will upload fix soon.
Attachments
Patch
(3.98 KB, patch)
2012-01-24 06:36 PST
,
Kaustubh Atrawalkar
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kaustubh Atrawalkar
Comment 1
2012-01-24 06:36:24 PST
Created
attachment 123724
[details]
Patch
Eric Seidel (no email)
Comment 2
2012-01-24 10:36:11 PST
Comment on
attachment 123724
[details]
Patch Is m_parentFrame ever null? I don't believe a Frame can ever have a null document, thankfully. :)
Kaustubh Atrawalkar
Comment 3
2012-01-25 04:54:13 PST
(In reply to
comment #2
)
> (From update of
attachment 123724
[details]
) > Is m_parentFrame ever null? I don't believe a Frame can ever have a null document, thankfully. :)
No, m_parentFrame can not be null and so as the document :)
WebKit Review Bot
Comment 4
2012-01-25 09:18:50 PST
Comment on
attachment 123724
[details]
Patch Clearing flags on attachment: 123724 Committed
r105883
: <
http://trac.webkit.org/changeset/105883
>
WebKit Review Bot
Comment 5
2012-01-25 09:18:54 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug