Bug 76904 - Reduce internal use of CSSStyleDeclaration base class
Summary: Reduce internal use of CSSStyleDeclaration base class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency tree / graph
 
Reported: 2012-01-24 04:44 PST by Antti Koivisto
Modified: 2012-02-03 09:38 PST (History)
3 users (show)

See Also:

Attachments
patch (22.03 KB, patch)
2012-01-24 05:04 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-01-24 04:44:55 PST 
Internally WebCore should use the more specific CSSMutableStyleDeclaration and CSSComputedStyleDeclaration types. The CSSStyleDeclaration base should be used in the DOM API functions only. This will make it easier to separate internal style sheet implementation from the DOM in the future.
Comment 1 Antti Koivisto 2012-01-24 05:04:34 PST 
Created attachment 123716 [details]
patch
Comment 2 WebKit Review Bot 2012-01-24 05:07:26 PST 
Attachment 123716 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/RenderLayer.cpp:49:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2012-01-24 08:09:28 PST 
http://trac.webkit.org/changeset/105739