Bug 76899 - [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
Summary: [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2012-01-24 02:46 PST by Carlos Garcia Campos
Modified: 2012-01-25 00:37 PST (History)
4 users (show)

See Also:

Patch (23.11 KB, patch)
2012-01-24 02:52 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-01-24 02:46:51 PST
They are now private and only provide a way to attach callbacks to the client.
Comment 1 Carlos Garcia Campos 2012-01-24 02:52:51 PST
Created attachment 123708 [details]
Comment 2 WebKit Review Bot 2012-01-24 02:54:19 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-01-24 06:48:19 PST
Comment on attachment 123708 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=123708&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:22
>  #include "WebKitWebLoaderClient.h"

Please rename this file to WebKitLoaderClient to match the name of the client now.
Comment 4 Carlos Garcia Campos 2012-01-25 00:37:21 PST
Committed r105854: <http://trac.webkit.org/changeset/105854>