Bug 76889 - [windows] Convert usage of GetDC to HWndDC Part 3.
Summary: [windows] Convert usage of GetDC to HWndDC Part 3.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on: 76737
Blocks: 76303
  Show dependency tree / graph
 
Reported: 2012-01-23 17:56 PST by David Levin
Modified: 2012-01-24 10:52 PST (History)
2 users (show)

See Also:

Attachments
Patch (7.24 KB, patch)
2012-01-23 18:02 PST, David Levin 		no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2012-01-24 09:06 PST, David Levin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Levin 2012-01-23 17:56:34 PST 
The files that needed to use setHWnd (and the other changes in those files as well).
Comment 1 David Levin 2012-01-23 18:02:45 PST 
Created attachment 123683 [details]
Patch
Comment 2 David Levin 2012-01-23 18:03:40 PST 
Last one!
Comment 3 WebKit Review Bot 2012-01-23 18:06:02 PST 
Attachment 123683 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:812:  Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Source/WebCore/platform/win/PopupMenuWin.cpp:571:  Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 David Levin 2012-01-24 01:21:03 PST 
Comment on attachment 123683 [details]
Patch

Need to fix the api call.
Comment 5 David Levin 2012-01-24 09:06:30 PST 
Created attachment 123746 [details]
Patch
Comment 6 WebKit Review Bot 2012-01-24 09:13:45 PST 
Attachment 123746 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebKit2/UIProcess/win/WebPopupMenuProxyWin.cpp:812:  Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Source/WebCore/platform/win/PopupMenuWin.cpp:571:  Use adoptPtr and OwnPtr<HDC> when calling CreateCompatibleDC to avoid potential memory leaks.  [runtime/leaky_pattern] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Review Bot 2012-01-24 10:52:06 PST 
Comment on attachment 123746 [details]
Patch

Clearing flags on attachment: 123746

Committed r105756: <http://trac.webkit.org/changeset/105756>
Comment 8 WebKit Review Bot 2012-01-24 10:52:11 PST 
All reviewed patches have been landed.  Closing bug.