Bug 76877 - [Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
Summary: [Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Performance, Qt
Depends on:
Blocks:
 
Reported: 2012-01-23 16:33 PST by Noam Rosenthal
Modified: 2012-01-24 07:17 PST (History)
6 users (show)

See Also:


Attachments
Patch (17.18 KB, patch)
2012-01-23 16:47 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff
Patch (16.25 KB, patch)
2012-01-23 16:51 PST, Noam Rosenthal
kenneth: review+
Details | Formatted Diff | Diff
Patch (16.41 KB, patch)
2012-01-24 06:21 PST, Noam Rosenthal
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (16.40 KB, patch)
2012-01-24 06:45 PST, Noam Rosenthal
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Noam Rosenthal 2012-01-23 16:33:27 PST
Apart from double buffering, update buffers go through several message queues, and get copied in between. This is unnecessary.
Comment 1 Noam Rosenthal 2012-01-23 16:47:39 PST
Created attachment 123658 [details]
Patch
Comment 2 Noam Rosenthal 2012-01-23 16:51:08 PST
Created attachment 123660 [details]
Patch
Comment 3 Kenneth Rohde Christiansen 2012-01-24 02:01:27 PST
Comment on attachment 123660 [details]
Patch

Nice!
Comment 4 Jocelyn Turcotte 2012-01-24 03:21:36 PST
Comment on attachment 123660 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123660&action=review

> Source/WebKit2/WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:92
> +    bitmap->swizzleRGB();

It's difficult to follow which format is used where, could you add a comment here saying from which to which you are converting?
Comment 5 Noam Rosenthal 2012-01-24 06:21:31 PST
Created attachment 123723 [details]
Patch

Added comments as per Jocelyn's request.
Comment 6 WebKit Review Bot 2012-01-24 06:24:44 PST
Comment on attachment 123723 [details]
Patch

Rejecting attachment 123723 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

NOBODY Kenneth Rohde Christiansen found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/11335374
Comment 7 Noam Rosenthal 2012-01-24 06:45:56 PST
Created attachment 123725 [details]
Patch
Comment 8 WebKit Review Bot 2012-01-24 07:17:26 PST
Comment on attachment 123725 [details]
Patch

Clearing flags on attachment: 123725

Committed r105737: <http://trac.webkit.org/changeset/105737>
Comment 9 WebKit Review Bot 2012-01-24 07:17:32 PST
All reviewed patches have been landed.  Closing bug.