Bug 76864 - Implement flex-pack:distribute
Summary: Implement flex-pack:distribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks: 62048
  Show dependency tree / graph
 
Reported: 2012-01-23 14:43 PST by Ojan Vafai
Modified: 2012-01-23 22:27 PST (History)
4 users (show)

See Also:

Attachments
Patch (9.97 KB, patch)
2012-01-23 14:45 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2012-01-23 15:35 PST, Ojan Vafai 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-23 14:43:27 PST 
Implement flex-pack:distribute
Comment 1 Ojan Vafai 2012-01-23 14:45:19 PST 
Created attachment 123626 [details]
Patch
Comment 2 Tony Chang 2012-01-23 15:26:40 PST 
Comment on attachment 123626 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123626&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You'll need to fix this.  It would also be nice to provide a link to the spec.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:584
> +        if (flexPack == PackDistribute)
> +            return availableFreeSpace / (2 * numberOfChildren);

What happens if we have 0 children?  Can we add a test case for that?
Comment 3 Ojan Vafai 2012-01-23 15:35:31 PST 
Created attachment 123637 [details]
Patch
Comment 4 WebKit Review Bot 2012-01-23 22:27:13 PST 
Comment on attachment 123637 [details]
Patch

Clearing flags on attachment: 123637

Committed r105694: <http://trac.webkit.org/changeset/105694>
Comment 5 WebKit Review Bot 2012-01-23 22:27:17 PST 
All reviewed patches have been landed.  Closing bug.