Bug 76864 - Implement flex-pack:distribute
: Implement flex-pack:distribute
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
: 62048
  Show dependency treegraph
 
Reported: 2012-01-23 14:43 PST by
Modified: 2012-01-23 22:27 PST (History)


Attachments
Patch (9.97 KB, patch)
2012-01-23 14:45 PST, Ojan Vafai
no flags Review Patch | Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2012-01-23 15:35 PST, Ojan Vafai
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-01-23 14:43:27 PST
Implement flex-pack:distribute
------- Comment #1 From 2012-01-23 14:45:19 PST -------
Created an attachment (id=123626) [details]
Patch
------- Comment #2 From 2012-01-23 15:26:40 PST -------
(From update of attachment 123626 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=123626&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You'll need to fix this.  It would also be nice to provide a link to the spec.

> Source/WebCore/rendering/RenderFlexibleBox.cpp:584
> +        if (flexPack == PackDistribute)
> +            return availableFreeSpace / (2 * numberOfChildren);

What happens if we have 0 children?  Can we add a test case for that?
------- Comment #3 From 2012-01-23 15:35:31 PST -------
Created an attachment (id=123637) [details]
Patch
------- Comment #4 From 2012-01-23 22:27:13 PST -------
(From update of attachment 123637 [details])
Clearing flags on attachment: 123637

Committed r105694: <http://trac.webkit.org/changeset/105694>
------- Comment #5 From 2012-01-23 22:27:17 PST -------
All reviewed patches have been landed.  Closing bug.