RESOLVED FIXED 76856
Convert DataTransferItem/DataTransferItemList back into an interface class 
https://bugs.webkit.org/show_bug.cgi?id=76856
Summary Convert DataTransferItem/DataTransferItemList back into an interface class
Daniel Cheng
Reported 2012-01-23 13:22:51 PST
Convert DataTransferItem/DataTransferItemList back into an interface class
Attachments
Patch (35.99 KB, patch)
2012-01-23 13:23 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Patch (36.38 KB, patch)
2012-01-23 14:29 PST, Daniel Cheng 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Daniel Cheng
Comment 1 2012-01-23 13:23:39 PST
Created attachment 123607 [details] Patch
Daniel Cheng
Comment 2 2012-01-23 14:29:05 PST
Created attachment 123621 [details] Patch
David Levin
Comment 3 2012-01-23 15:28:39 PST
Comment on attachment 123621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review > Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65 > + RefPtr<Clipboard> m_owner; Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ?
Daniel Cheng
Comment 4 2012-01-23 15:32:02 PST
(In reply to comment #3) > (From update of attachment 123621 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review > > > Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65 > > + RefPtr<Clipboard> m_owner; > > Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ? As discusses, this code will be disappearing shortly anyway.
Daniel Cheng
Comment 5 2012-01-23 15:35:52 PST
Comment on attachment 123621 [details] Patch Clearing flags on attachment: 123621 Committed r105648: <http://trac.webkit.org/changeset/105648>
Daniel Cheng
Comment 6 2012-01-23 15:35:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.