Bug 76856 - Convert DataTransferItem/DataTransferItemList back into an interface class
Summary: Convert DataTransferItem/DataTransferItemList back into an interface class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Cheng
URL:
Keywords:
Depends on:
Blocks: 76598
  Show dependency treegraph
 
Reported: 2012-01-23 13:22 PST by Daniel Cheng
Modified: 2012-01-23 15:35 PST (History)
2 users (show)

See Also:


Attachments
Patch (35.99 KB, patch)
2012-01-23 13:23 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff
Patch (36.38 KB, patch)
2012-01-23 14:29 PST, Daniel Cheng
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Cheng 2012-01-23 13:22:51 PST
Convert DataTransferItem/DataTransferItemList back into an interface class
Comment 1 Daniel Cheng 2012-01-23 13:23:39 PST
Created attachment 123607 [details]
Patch
Comment 2 Daniel Cheng 2012-01-23 14:29:05 PST
Created attachment 123621 [details]
Patch
Comment 3 David Levin 2012-01-23 15:28:39 PST
Comment on attachment 123621 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review

> Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65
> +    RefPtr<Clipboard> m_owner;

Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ?
Comment 4 Daniel Cheng 2012-01-23 15:32:02 PST
(In reply to comment #3)
> (From update of attachment 123621 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123621&action=review
> 
> > Source/WebCore/platform/chromium/DataTransferItemListChromium.h:65
> > +    RefPtr<Clipboard> m_owner;
> 
> Why not make this a RefPtr<ClipboardChromium> and ditto for the create methods now that they are Chromium specific ?

As discusses, this code will be disappearing shortly anyway.
Comment 5 Daniel Cheng 2012-01-23 15:35:52 PST
Comment on attachment 123621 [details]
Patch

Clearing flags on attachment: 123621

Committed r105648: <http://trac.webkit.org/changeset/105648>
Comment 6 Daniel Cheng 2012-01-23 15:35:56 PST
All reviewed patches have been landed.  Closing bug.