Bug 76846 - [Refactoring] Make finish() of CodeGeneratorJS.pm empty
Summary: [Refactoring] Make finish() of CodeGeneratorJS.pm empty
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 76836
  Show dependency tree / graph
 
Reported: 2012-01-23 11:21 PST by Kentaro Hara
Modified: 2012-01-24 18:16 PST (History)
6 users (show)

See Also:

Attachments
Patch (7.97 KB, patch)
2012-01-23 11:36 PST, Kentaro Hara 		no flags Details | Formatted Diff | Diff
proposed warning fix (1.31 KB, patch)
2012-01-24 00:04 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-23 11:21:34 PST 
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

As a refactoring, we are planning to remove finish() from all CodeGenerators. In this bug, we make finish() of CodeGeneratorJS.pm empty.
Comment 1 Kentaro Hara 2012-01-23 11:36:03 PST 
Created attachment 123585 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-23 20:00:15 PST 
Comment on attachment 123585 [details]
Patch

Clearing flags on attachment: 123585

Committed r105683: <http://trac.webkit.org/changeset/105683>
Comment 3 WebKit Review Bot 2012-01-23 20:00:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-01-23 23:55:57 PST 
Comment on attachment 123585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123585&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3251
> +    my @includes = ();

Here is the first declaration.

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:3290
> +    my @includes = ();

This change caused the following warning:
"my" variable @includes masks earlier declaration in same scope at /home/oszi/WebKit/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm line 3290.
Comment 5 Csaba Osztrogonác 2012-01-24 00:04:18 PST 
Reopening to attach new patch.
Comment 6 Csaba Osztrogonác 2012-01-24 00:04:23 PST 
Created attachment 123703 [details]
proposed warning fix
Comment 7 Csaba Osztrogonác 2012-01-24 05:58:39 PST 
Comment on attachment 123703 [details]
proposed warning fix

Landed in http://trac.webkit.org/changeset/105734
Comment 8 Simon Fraser (smfr) 2012-01-24 15:14:26 PST 
When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.
Comment 9 Kentaro Hara 2012-01-24 16:59:23 PST 
(In reply to comment #8)
> When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.

smfr: I was able to reproduce it. I'll fix it.
Comment 10 Kentaro Hara 2012-01-24 18:16:41 PST 
(In reply to comment #8)
> When I do incremental builds today, I see all IDL files being processed every time. This didn't used to happen.

smfr: Fixed it in bug 76970.