Bug 76843 - Web Inspector: show memory counter graphs in timeline panel
Summary: Web Inspector: show memory counter graphs in timeline panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 11:14 PST by Yury Semikhatsky
Modified: 2012-01-25 07:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (32.73 KB, patch)
2012-01-23 11:40 PST, Yury Semikhatsky 		pfeldman: review+
Details | Formatted Diff | Diff
Screenshot with the patch applied (95.59 KB, image/png)
2012-01-25 03:46 PST, Yury Semikhatsky 		no flags Details
Patch for landing (36.64 KB, patch)
2012-01-25 06:40 PST, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-01-23 11:14:43 PST 
This is an experimental feature which allows to view dynamics of various DOM counters including total node count, number of DOM groups and number of event listeners in the document.
Comment 1 Yury Semikhatsky 2012-01-23 11:40:48 PST 
Created attachment 123589 [details]
Patch
Comment 2 Pavel Feldman 2012-01-25 00:55:04 PST 
Is there a screenshot?
Comment 3 Yury Semikhatsky 2012-01-25 03:46:57 PST 
Created attachment 123916 [details]
Screenshot with the patch applied
Comment 4 Pavel Feldman 2012-01-25 04:00:04 PST 
Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

> Source/WebCore/inspector/Inspector.json:1897
> +                "name": "setDomCountersEnabled",

setIncludeMemoryDetails ?

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
> +        m_recordStack.last().record->setArray("memory", domGroups.release());

This field seems to conflict with the heap info we are sending.

> Source/WebCore/inspector/front-end/TimelinePanel.js:155
> +WebInspector.MemoryStatistics.prototype = {

Could you extract this into a separate file?
Comment 5 Yury Semikhatsky 2012-01-25 06:40:13 PST 
Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

>> Source/WebCore/inspector/Inspector.json:1897
>> +                "name": "setDomCountersEnabled",
> 
> setIncludeMemoryDetails ?

Done.

>> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
>> +        m_recordStack.last().record->setArray("memory", domGroups.release());
> 
> This field seems to conflict with the heap info we are sending.

Renamed to domGroups for now.

>> Source/WebCore/inspector/front-end/TimelinePanel.js:155
>> +WebInspector.MemoryStatistics.prototype = {
> 
> Could you extract this into a separate file?

Done.
Comment 6 Yury Semikhatsky 2012-01-25 06:40:52 PST 
Created attachment 123930 [details]
Patch for landing
Comment 7 Yury Semikhatsky 2012-01-25 07:10:59 PST 
Committed r105877: <http://trac.webkit.org/changeset/105877>