Bug 76843 – Web Inspector: show memory counter graphs in timeline panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Yury Semikhatsky]

This is an experimental feature which allows to view dynamics of various DOM counters including total node count, number of DOM groups and number of event listeners in the document.

[Yury Semikhatsky]

Created attachment 123589 [details]
Patch

[Pavel Feldman]

Is there a screenshot?

[Yury Semikhatsky]

Created attachment 123916 [details]
Screenshot with the patch applied

[Pavel Feldman]

Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

> Source/WebCore/inspector/Inspector.json:1897
> +                "name": "setDomCountersEnabled",

setIncludeMemoryDetails ?

> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
> +        m_recordStack.last().record->setArray("memory", domGroups.release());

This field seems to conflict with the heap info we are sending.

> Source/WebCore/inspector/front-end/TimelinePanel.js:155
> +WebInspector.MemoryStatistics.prototype = {

Could you extract this into a separate file?

[Yury Semikhatsky]

Comment on attachment 123589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123589&action=review

>> Source/WebCore/inspector/Inspector.json:1897
>> +                "name": "setDomCountersEnabled",
> 
> setIncludeMemoryDetails ?

Done.

>> Source/WebCore/inspector/InspectorTimelineAgent.cpp:412
>> +        m_recordStack.last().record->setArray("memory", domGroups.release());
> 
> This field seems to conflict with the heap info we are sending.

Renamed to domGroups for now.

>> Source/WebCore/inspector/front-end/TimelinePanel.js:155
>> +WebInspector.MemoryStatistics.prototype = {
> 
> Could you extract this into a separate file?

Done.

[Yury Semikhatsky]

Created attachment 123930 [details]
Patch for landing

[Yury Semikhatsky]

Committed r105877: <http://trac.webkit.org/changeset/105877>