Bug 76841 - [Refactoring] Remove finish() from CodeGeneratorV8.pm
Summary: [Refactoring] Remove finish() from CodeGeneratorV8.pm
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 76836
  Show dependency treegraph
Reported: 2012-01-23 10:52 PST by Kentaro Hara
Modified: 2012-01-24 02:33 PST (History)
4 users (show)

See Also:

Patch (6.26 KB, patch)
2012-01-23 11:01 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff
rebased patch for review (6.24 KB, patch)
2012-01-23 22:06 PST, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-01-23 10:52:10 PST
This is one of steps to stop rebuilding .h/.cpp files generated by unchanged IDLs (bug 76836).

As refactoring, we are planning to remove finish() from all CodeGenerators. In this bug, we remove finish() from CodeGeneratorV8.pm.
Comment 1 Kentaro Hara 2012-01-23 11:01:55 PST
Created attachment 123576 [details]
Comment 2 WebKit Review Bot 2012-01-23 22:00:42 PST
Comment on attachment 123576 [details]

Rejecting attachment 123576 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
ion 55 --non-interactive --force --accept theirs-conflict --ignore-externals returned non-zero exit status 1 in /mnt/git/webkit-commit-queue/Source/WebKit/chromium
Error: 'depot_tools/gclient sync --force --reset --delete_unversioned_trees' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 106.
Re-trying 'depot_tools/gclient sync --force --reset --delete_unversioned_trees'
No such file or directory at /mnt/git/webkit-commit-queue/Tools/Scripts/webkitdirs.pm line 2302.

Full output: http://queues.webkit.org/results/11333241
Comment 3 Kentaro Hara 2012-01-23 22:06:02 PST
Created attachment 123697 [details]
rebased patch for review
Comment 4 Kentaro Hara 2012-01-23 22:07:20 PST
adam: Sorry, would you please r+ again? I forgot to add --no-review option.
Comment 5 WebKit Review Bot 2012-01-24 02:33:03 PST
Comment on attachment 123697 [details]
rebased patch for review

Clearing flags on attachment: 123697

Committed r105714: <http://trac.webkit.org/changeset/105714>
Comment 6 WebKit Review Bot 2012-01-24 02:33:08 PST
All reviewed patches have been landed.  Closing bug.