Bug 76837 - Web Inspector: incorrect highlight position when searching in console
Summary: Web Inspector: incorrect highlight position when searching in console
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 09:52 PST by Yury Semikhatsky
Modified: 2012-01-24 10:56 PST (History)
10 users (show)

See Also:

Attachments
Screenshot (245.92 KB, image/png)
2012-01-23 09:52 PST, Yury Semikhatsky 		no flags Details
Patch (8.90 KB, patch)
2012-01-24 09:37 PST, Vsevolod Vlasov 		yurys: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-01-23 09:52:03 PST 
Created attachment 123569 [details]
Screenshot

See attached screenshot.
Comment 1 Vsevolod Vlasov 2012-01-24 09:37:10 PST 
Created attachment 123751 [details]
Patch
Comment 2 Yury Semikhatsky 2012-01-24 10:30:36 PST 
Comment on attachment 123751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123751&action=review

> Source/WebCore/inspector/front-end/ConsoleMessage.js:417
> +        return regexObject.test(this._messageElement.textContent) || (this._anchorElement && regexObject.test(this._anchorElement.textContent));

Please use cached this._message instead of this._messageElement.textContent here.
Comment 3 Vsevolod Vlasov 2012-01-24 10:56:11 PST 
Committed r105758: <http://trac.webkit.org/changeset/105758>