Bug 76827 - Eliminate CSSElementStyleDeclaration subclasses
Summary: Eliminate CSSElementStyleDeclaration subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 77745
  Show dependency tree / graph
 
Reported: 2012-01-23 07:11 PST by Antti Koivisto
Modified: 2012-02-03 09:38 PST (History)
3 users (show)

See Also:

Attachments
patch (24.45 KB, patch)
2012-01-23 08:41 PST, Antti Koivisto 		kling: review+
gyuyoung.kim: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-01-23 07:11:59 PST 
CSSInlineStyleDeclaration and FontFaceStyleDeclaration serve no purpose.
Comment 1 Antti Koivisto 2012-01-23 08:41:32 PST 
Created attachment 123564 [details]
patch
Comment 2 WebKit Review Bot 2012-01-23 08:44:11 PST 
Attachment 123564 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/css/CSSElementStyleDeclaration.h:40:  The parameter name "element" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2012-01-23 08:46:34 PST 
Comment on attachment 123564 [details]
patch

Oh god make it go away. r=me
Comment 4 Antti Koivisto 2012-01-23 08:49:56 PST 
http://trac.webkit.org/changeset/105630
Comment 5 Csaba Osztrogonác 2012-01-23 09:03:09 PST 
It broke the (Qt) build:

../../../../Source/WebCore/css/CSSElementStyleDeclaration.cpp: In static member function ‘static WTF::PassRefPtr<WebCore::CSSElementStyleDeclaration> WebCore::CSSElementStyleDeclaration::createForSVGFontFaceElement(WebCore::SVGFontFaceElement*)’:
../../../../Source/WebCore/css/CSSElementStyleDeclaration.cpp:36: error: no matching function for call to ‘WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(WebCore::SVGFontFaceElement*&, bool)’
../../../../Source/WebCore/css/CSSElementStyleDeclaration.h:48: note: candidates are: WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(WebCore::StyledElement*, bool)
../../../../Source/WebCore/css/CSSElementStyleDeclaration.h:37: note:                 WebCore::CSSElementStyleDeclaration::CSSElementStyleDeclaration(const WebCore::CSSElementStyleDeclaration&)

Could you guys fix it?
Comment 6 Gyuyoung Kim 2012-01-23 09:10:43 PST 
Comment on attachment 123564 [details]
patch

Attachment 123564 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11284675
Comment 7 Antti Koivisto 2012-01-23 09:43:10 PST 
Fixed SVG_FONTS=0 build in http://trac.webkit.org/changeset/105632