Bug 76813 - Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the expandable tree (to get rid of cycles)
Summary: Web Inspector: DetailedHeapSnapshot: Replace the list of retainers with the e...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
Depends on:
Blocks: 78411
  Show dependency treegraph
Reported: 2012-01-23 00:49 PST by Ilya Tikhonovsky
Modified: 2012-02-11 01:26 PST (History)
10 users (show)

See Also:

Patch (15.85 KB, patch)
2012-01-23 00:51 PST, Ilya Tikhonovsky
pfeldman: review+
Details | Formatted Diff | Diff
screenshot (155.86 KB, image/png)
2012-01-23 01:09 PST, Ilya Tikhonovsky
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-01-23 00:49:10 PST
Comment 1 Ilya Tikhonovsky 2012-01-23 00:51:59 PST
Created attachment 123527 [details]
Comment 2 Pavel Feldman 2012-01-23 00:58:38 PST
Comment on attachment 123527 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=123527&action=review

Looks sane.

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:194
> +    },

trailing comma

> Source/WebCore/inspector/front-end/DetailedHeapshotView.js:462
> +    retainingPathsTitle.textContent = WebInspector.UIString("Object's retaining tree");

Please bring localized strings in sync with the change.
Comment 3 Ilya Tikhonovsky 2012-01-23 01:09:43 PST
Created attachment 123528 [details]
Comment 4 Ilya Tikhonovsky 2012-01-23 01:24:07 PST
Committed r105598: <http://trac.webkit.org/changeset/105598>