Bug 76808 – Web Inspector: Inspecting an element inside an iframe no longer works

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Darth]

On a page with an iframe, for example http://www.iframehtml.com/ try to right click and inspect some dom element inside the iframe.
Web inspector fails to drill down to the element. Same thing can be noticed if using the magnifying/search glass icon.

This seems a regression, possibly related to #document change https://bugs.webkit.org/show_bug.cgi?id=76550

If you manually open the iframe in web inspector and try right clicking the element on the page and inspecting again, it will then properly drill down to the element in the inspector.

[Pavel Feldman]

Created attachment 123553 [details]
Patch

[Timothy Hatcher]

Comment on attachment 123553 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123553&action=review

> Source/WebCore/inspector/front-end/DOMAgent.js:243
>          }
> -
>          DOMAgent.requestChildNodes(this.id, mycallback.bind(this));

I prefer empty lines line this. Otherwise it feels too crowded.

> Source/WebCore/inspector/front-end/DOMAgent.js:402
> +        if (this._contentDocument)
> +            return;

Maybe this deserves a comment? It needs to be this way because the children are set in the constructor?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 123553 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123553&action=review
> 
> > Source/WebCore/inspector/front-end/DOMAgent.js:243
> >          }
> > -
> >          DOMAgent.requestChildNodes(this.id, mycallback.bind(this));
> 
> I prefer empty lines line this. Otherwise it feels too crowded.
> 

Done.

> > Source/WebCore/inspector/front-end/DOMAgent.js:402
> > +        if (this._contentDocument)
> > +            return;
> 
> Maybe this deserves a comment? It needs to be this way because the children are set in the constructor?

Done.

[Pavel Feldman]

Committed r105620: <http://trac.webkit.org/changeset/105620>