RESOLVED FIXED76806
Implement cast between CSSPrimitiveValue and LineClampValue. 
https://bugs.webkit.org/show_bug.cgi?id=76806
Summary Implement cast between CSSPrimitiveValue and LineClampValue.
Luke Macpherson
Reported 2012-01-22 20:46:58 PST
Implement cast between CSSPrimitiveValue and LineClampValue.
Attachments
Patch (3.38 KB, patch)
2012-01-22 20:49 PST, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.51 KB, patch)
2012-03-15 20:19 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2012-01-22 20:49:14 PST
Created attachment 123514 [details] Patch
Andreas Kling
Comment 2 2012-01-24 15:29:50 PST
Comment on attachment 123514 [details] Patch r=me
WebKit Review Bot
Comment 3 2012-01-24 16:46:52 PST
Comment on attachment 123514 [details] Patch Rejecting attachment 123514 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ngeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/css/CSSPrimitiveValueMappings.h Hunk #1 FAILED at 36. Hunk #2 succeeded at 135 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSPrimitiveValueMappings.h.rej patching file Source/WebCore/css/CSSStyleSelector.cpp Hunk #1 succeeded at 3326 (offset -40 lines). Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1 Full output: http://queues.webkit.org/results/11242370
WebKit Review Bot
Comment 4 2012-03-14 17:04:02 PDT
Comment on attachment 123514 [details] Patch Rejecting attachment 123514 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: nk #1 FAILED at 36. Hunk #2 succeeded at 135 (offset 1 line). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/css/CSSPrimitiveValueMappings.h.rej patching file Source/WebCore/css/CSSStyleSelector.cpp Hunk #1 FAILED at 3366. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/css/CSSStyleSelector.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Andreas Kl..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/11954371
Luke Macpherson
Comment 5 2012-03-15 20:19:32 PDT
Created attachment 132181 [details] Patch for landing
WebKit Review Bot
Comment 6 2012-03-16 04:26:12 PDT
Comment on attachment 132181 [details] Patch for landing Clearing flags on attachment: 132181 Committed r110985: <http://trac.webkit.org/changeset/110985>
WebKit Review Bot
Comment 7 2012-03-16 04:26:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.