Bug 76803 – [V8] Add Uint8ClampedArray support

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kenichi Ishibashi]

JSC supports Uint8ClampedArray as of r105217. It would be better to support it on V8.

[Kenichi Ishibashi]

Created attachment 123516 [details]
Patch

[Kenneth Russell]

Comment on attachment 123516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review

Thanks very much for filing and fixing this. Marking r+, but please see the above comments (in particular about getting rid of the separate Chromium baseline for array-unit-tests.html) and watch the EWS bots before committing.

> Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16
> + * this software without specific prior written permission.

Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here).

> LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1
> -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined

Can you just remove this expectation at this point? I don't think it should be needed any more.

[Kenichi Ishibashi]

Created attachment 123643 [details]
Patch for landing

[Kenichi Ishibashi]

Comment on attachment 123516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123516&action=review

Thank you for review!

>> Source/WebCore/bindings/v8/custom/V8Uint8ClampedArrayCustom.cpp:16
>> + * this software without specific prior written permission.
> 
> Wrong version of copyright notice; should be the two-clause license from Source/WebKit/LICENSE (with copyright Google, as you have here).

Done.

>> LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt:-1
>> -CONSOLE MESSAGE: line 222: Uncaught ReferenceError: Uint8ClampedArray is not defined
> 
> Can you just remove this expectation at this point? I don't think it should be needed any more.

Done.

[Kenneth Russell]

I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch.

[Kenichi Ishibashi]

Created attachment 123672 [details]
Patch for landing

[Kenichi Ishibashi]

(In reply to comment #5)
> I don't see the deletion of LayoutTests/platform/chromium/fast/canvas/webgl/array-unit-tests-expected.txt in the above patch.

Revised the patch. Thank you for pointing this out.

[WebKit Review Bot]

Comment on attachment 123672 [details]
Patch for landing

Clearing flags on attachment: 123672

Committed r105705: <http://trac.webkit.org/changeset/105705>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.