Bug 76779 - [BlackBerry]Use extension for a mimetype as the suggested extension if the url file doesn't have an extension.
Summary: [BlackBerry]Use extension for a mimetype as the suggested extension if the ur...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-01-21 00:31 PST by Charles Wei
Modified: 2012-02-06 05:55 PST (History)
4 users (show)

See Also:

Patch (2.74 KB, patch)
2012-02-06 02:55 PST, Charles Wei
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Charles Wei 2012-01-21 00:31:35 PST
If the url file doesn't have an extension,  like http://domain/noextension, we should try to append the extension of the mime type to the suggested file.  like if it happen to be a text file indicated by the MIME,  we should suggest the file name as : noextension.txt
Comment 1 Charles Wei 2012-02-06 02:55:07 PST
Created attachment 125606 [details]
Comment 2 Rob Buis 2012-02-06 05:45:44 PST
Comment on attachment 125606 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=125606&action=review

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:614
> +    // fill it in from the url and sniffed mime type;Skip this for data and about URLs,

the Skip section seems untidy. Needs a space and no need for capital S.

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:625
> +                    suggestedFilename = String("Untitled") + "." + mimeExtension;

This could be done differently:
suggestedFilename = String("Untitled");
if (!mimeExtension.isEmpty()) // No extension found for the mimeType.
    suggestedFilename = "." + mimeExtension;

> Source/WebCore/platform/network/blackberry/NetworkJob.cpp:630
> +                   suggestedFilename = urlFilename;

Comment 3 WebKit Review Bot 2012-02-06 05:55:28 PST
Comment on attachment 125606 [details]

Clearing flags on attachment: 125606

Committed r106802: <http://trac.webkit.org/changeset/106802>
Comment 4 WebKit Review Bot 2012-02-06 05:55:32 PST
All reviewed patches have been landed.  Closing bug.