Bug 76771 - PopupMenuClient::multiple() should be const
Summary: PopupMenuClient::multiple() should be const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: EasyFix
Depends on:
Blocks:
 
Reported: 2012-01-20 22:37 PST by Benjamin Poulain
Modified: 2012-01-21 00:17 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2012-01-20 22:43 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-01-20 22:37:20 PST 
It is an accessor, no reason to have it modify the RenderObject.
Comment 1 Benjamin Poulain 2012-01-20 22:43:45 PST 
Created attachment 123432 [details]
Patch
Comment 2 Kent Tamura 2012-01-20 22:49:07 PST 
Comment on attachment 123432 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123432&action=review

> Source/WebCore/rendering/RenderMenuList.h:110
> +    virtual bool multiple() const;

I recommend adding OVERRIDE to this line.
Comment 3 Benjamin Poulain 2012-01-20 23:01:04 PST 
> I recommend adding OVERRIDE to this line.

Yeah, I considered that.

But I think I should modify the whole interface on one patch instead of a single method.
Comment 4 Kent Tamura 2012-01-20 23:06:26 PST 
Comment on attachment 123432 [details]
Patch

ok
Comment 5 WebKit Review Bot 2012-01-21 00:17:43 PST 
Comment on attachment 123432 [details]
Patch

Clearing flags on attachment: 123432

Committed r105570: <http://trac.webkit.org/changeset/105570>
Comment 6 WebKit Review Bot 2012-01-21 00:17:47 PST 
All reviewed patches have been landed.  Closing bug.