Bug 76767 – Move IndexedDB code to new Modules/indexeddb/ directory

• Status: CLOSED
• Resolution: WONTFIX
• Component: New Bugs

[Mark Pilgrim (Google)]

Move IndexedDB code to new Modules/indexeddb/ directory

[Mark Pilgrim (Google)]

Created attachment 123430 [details]
Patch

[Adam Barth]

Yay

[Adam Barth]

I'll mark it commit-queue+ once it runs through the EWS for a bit.

[WebKit Review Bot]

Attachment 123430 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/Modules/indexeddb/IDBObjectStore.h:73:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:62:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBBackingStore.h:76:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h:51:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:514:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:1000:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:47:  Missing space inside { }.  [whitespace/braces] [5]
Source/WebCore/Modules/indexeddb/IDBCursorBackendInterface.h:62:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:282:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/Modules/indexeddb/IDBPendingTransactionMonitor.cpp:27:  You should add a blank line after implementation file's own header.  [build/include_order] [4]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:69:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:71:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:78:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:92:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:94:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h:98:  The parameter name "range" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBTransactionBackendInterface.h:54:  The parameter name "task" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:31:  "EventQueue.h" already included at Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:29  [build/include] [4]
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp:43:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 20 in 86 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Gyuyoung Kim]

Comment on attachment 123430 [details]
Patch

Attachment 123430 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/11246269

[Early Warning System Bot]

Comment on attachment 123430 [details]
Patch

Attachment 123430 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/11313255

[Adam Barth]

Looks like some of the other build system need to be updated.

[Mark Pilgrim (Google)]

Created attachment 124208 [details]
Patch

[Adam Barth]

Comment on attachment 124208 [details]
Patch

LGTM, assuming it builds.

[Mark Pilgrim (Google)]

Comment on attachment 124208 [details]
Patch

Looks like EWS gave no errors. Can you commit this?

[Adam Barth]

> Looks like EWS gave no errors. Can you commit this?

I mean, the none of the EWS bots were able to process this patch.  We can try committing it when the tree is quiet because it's likely to break something.

[Mark Pilgrim (Google)]

Already fixed in another rollup patch.