Bug 76759 - Switch media/audio-data-url.html layout test to base64-encoded WAV data
Summary: Switch media/audio-data-url.html layout test to base64-encoded WAV data
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andrew Scherkus
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 17:16 PST by Andrew Scherkus
Modified: 2012-01-23 17:16 PST (History)
3 users (show)

See Also:


Attachments
Patch (29.62 KB, patch)
2012-01-20 17:19 PST, Andrew Scherkus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Scherkus 2012-01-20 17:16:56 PST
While working on Chromium's networking code I was worried that I might regress data:// support. Turns out we're not running the test at all (!!!) as the test uses 3gpp.

I changed the base64-encoded data to 250ms of silent WAV data instead and updated the expectations. Tested on Chromium and Mac ports.
Comment 1 Andrew Scherkus 2012-01-20 17:19:51 PST
Created attachment 123417 [details]
Patch
Comment 2 WebKit Review Bot 2012-01-20 20:53:49 PST
Comment on attachment 123417 [details]
Patch

Attachment 123417 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11312279

New failing tests:
media/audio-garbage-collect.html
Comment 3 Andrew Scherkus 2012-01-23 17:16:35 PST
Comment on attachment 123417 [details]
Patch

Clearing flags on attachment: 123417

Committed r105664: <http://trac.webkit.org/changeset/105664>
Comment 4 Andrew Scherkus 2012-01-23 17:16:39 PST
All reviewed patches have been landed.  Closing bug.