RESOLVED FIXED 76755
[GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible 
https://bugs.webkit.org/show_bug.cgi?id=76755
Summary [GTK][WK2] Make the LoadTracking and WebView test fixtures more flexible
Martin Robinson
Reported 2012-01-20 16:41:46 PST
The load tracking and a WebView fixtures are a little bit hard to use because they have internal assertions. This bugs tracks make them resilient to different types of usage.
Attachments
Patch (7.79 KB, patch)
2012-01-20 16:49 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-01-20 16:49:43 PST
Created attachment 123411 [details] Patch
WebKit Review Bot
Comment 2 2012-01-20 16:53:23 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Martin Robinson
Comment 3 2012-01-21 09:18:30 PST
I think this dependency was added accidentally. Andre, I hope you don't mind if I remove it.
Carlos Garcia Campos
Comment 4 2012-01-23 00:10:15 PST
Comment on attachment 123411 [details] Patch Perfect!
Alejandro G. Castro
Comment 5 2012-01-23 10:14:58 PST
Comment on attachment 123411 [details] Patch LGTM
WebKit Review Bot
Comment 6 2012-01-23 17:24:54 PST
Comment on attachment 123411 [details] Patch Rejecting attachment 123411 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Alejandro G found in /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebKit2/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/11336130
Martin Robinson
Comment 7 2012-01-23 20:40:38 PST
Comment on attachment 123411 [details] Patch Clearing flags on attachment: 123411 Committed r105688: <http://trac.webkit.org/changeset/105688>
Martin Robinson
Comment 8 2012-01-23 20:40:42 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.