Bug 76754 - Fine tune Web Intents Chromium API
Summary: Fine tune Web Intents Chromium API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Greg Billock
URL:
Keywords:
Depends on:
Blocks: 75123
  Show dependency tree / graph
 
Reported: 2012-01-20 16:30 PST by Greg Billock
Modified: 2012-01-23 19:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (3.39 KB, patch)
2012-01-20 16:31 PST, Greg Billock 		no flags Details | Formatted Diff | Diff
Patch (3.44 KB, patch)
2012-01-23 10:31 PST, Greg Billock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Billock 2012-01-20 16:30:23 PST 
Fine tune Web Intents Chromium API
Comment 1 Greg Billock 2012-01-20 16:31:53 PST 
Created attachment 123406 [details]
Patch
Comment 2 Greg Billock 2012-01-20 16:34:45 PST 
Removes identifier() method from Web Intent, adds webkit constructor for WebIntentServiceInfo.

This shouldn't be merged until after the Chromium code using the removed API lands (http://codereview.chromium.org/9186021/)
Comment 3 WebKit Review Bot 2012-01-20 16:36:28 PST 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 4 Darin Fisher (:fishd, Google) 2012-01-20 20:45:27 PST 
Comment on attachment 123406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review

> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,

nit: please list functions in the .cpp file in the same order as they appear in the .h file.
Comment 5 Greg Billock 2012-01-23 10:30:16 PST 
Comment on attachment 123406 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123406&action=review

>> Source/WebKit/chromium/src/WebIntentServiceInfo.cpp:36
>> +WebIntentServiceInfo::WebIntentServiceInfo(const WebString& action,
> 
> nit: please list functions in the .cpp file in the same order as they appear in the .h file.

Done.
Comment 6 Greg Billock 2012-01-23 10:31:22 PST 
Created attachment 123573 [details]
Patch
Comment 7 WebKit Review Bot 2012-01-23 19:20:24 PST 
Comment on attachment 123573 [details]
Patch

Clearing flags on attachment: 123573

Committed r105681: <http://trac.webkit.org/changeset/105681>
Comment 8 WebKit Review Bot 2012-01-23 19:20:29 PST 
All reviewed patches have been landed.  Closing bug.