Bug 76748 - run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
Summary: run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 15:16 PST by Ojan Vafai
Modified: 2012-01-20 22:56 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.86 KB, patch)
2012-01-20 15:17 PST, Ojan Vafai 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-01-20 15:16:20 PST 
run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
Comment 1 Ojan Vafai 2012-01-20 15:17:28 PST 
Created attachment 123391 [details]
Patch
Comment 2 Ryosuke Niwa 2012-01-20 15:28:39 PST 
That's why it was so slow!
Comment 3 Dirk Pranke 2012-01-20 15:42:54 PST 
Comment on attachment 123391 [details]
Patch

Yup, I just noticed this as well :( See also bug 76749, which we might want to land instead of this.
Comment 4 Dirk Pranke 2012-01-20 15:44:40 PST 
That said, given that the second time you're collecting tests the filesystem is largely in cache, I wonder how much slower that is now? I.e., what is the total time for collecting twice or once?
Comment 5 Ojan Vafai 2012-01-20 15:47:15 PST 
Committed r105551: <http://trac.webkit.org/changeset/105551>
Comment 6 Tony Chang 2012-01-20 22:56:13 PST 
Can we add a test to prevent this from regressing (again?)?  Might be a bit tricky.