Bug 76728 - [chromium] Plumb damage from accelerated canvas 2D.
Summary: [chromium] Plumb damage from accelerated canvas 2D.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Backer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 12:39 PST by Jonathan Backer
Modified: 2012-01-20 16:11 PST (History)
5 users (show)

See Also:


Attachments
Patch (1.29 KB, patch)
2012-01-20 12:39 PST, Jonathan Backer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Backer 2012-01-20 12:39:08 PST
[chromium] Plumb damage from accelerated canvas 2D.
Comment 1 Jonathan Backer 2012-01-20 12:39:38 PST
Created attachment 123363 [details]
Patch
Comment 2 Shawn Singh 2012-01-20 12:44:14 PST
Comment on attachment 123363 [details]
Patch

Thanks for this, LGTM.  Somehow this line of code disappeared since I had added it a few months ago.  And the new placement of this line seems good, too, but perhaps jamesr should take a look and verify.
Comment 3 Adrienne Walker 2012-01-20 13:41:15 PST
Comment on attachment 123363 [details]
Patch

LGTM.
Comment 4 Kenneth Russell 2012-01-20 13:42:47 PST
Comment on attachment 123363 [details]
Patch

rs=me based on enne's review.
Comment 5 WebKit Review Bot 2012-01-20 14:50:05 PST
Comment on attachment 123363 [details]
Patch

Clearing flags on attachment: 123363

Committed r105544: <http://trac.webkit.org/changeset/105544>
Comment 6 WebKit Review Bot 2012-01-20 14:50:10 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 James Robinson 2012-01-20 16:11:58 PST
This is fine, but in the future if somebody wants to tighten up the bounds you can take a look at propagating the dirtyRect from CanvasRenderingContext2D::didDraw() through to this logic rather than considering the whole canvas dirty.