Bug 76721 – history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)

• Status: RESOLVED
• Resolution: FIXED
• Component: History

[Darin Fisher (:fishd, Google)]

history.replaceState should update the HistoryItem to use a GET method if previously non-GET (POST)

This is about implementing step #4 under http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#dom-history-replacestate

  4. If the current entry in the session history represents a non-GET request (e.g.
     it was the result of a POST submission) then update it to instead represent 
     a GET request (or equivalent).

Created attachment 123390 [details]
Patch

[Mihai Parparita]

Comment on attachment 123390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123390&action=review

> LayoutTests/http/tests/history/resources/replacestate-current.php:9
> +        history.go(0);

Nit: location.reload() would be a more explicit way of doing a page reload.

(In reply to comment #2)
> (From update of attachment 123390 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123390&action=review
> 
> > LayoutTests/http/tests/history/resources/replacestate-current.php:9
> > +        history.go(0);
> 
> Nit: location.reload() would be a more explicit way of doing a page reload.

I test history.go(0) as this code path is special cased

[WebKit Review Bot]

Comment on attachment 123390 [details]
Patch

Clearing flags on attachment: 123390

Committed r105574: <http://trac.webkit.org/changeset/105574>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.