Bug 76705 - Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
Summary: Web Inspector: IndexedDBModel should keep track of requests sent to the backend.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks: 75386
  Show dependency tree / graph
 
Reported: 2012-01-20 08:01 PST by Vsevolod Vlasov
Modified: 2012-01-23 07:17 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.92 KB, patch)
2012-01-20 08:35 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (13.97 KB, patch)
2012-01-20 08:58 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (15.38 KB, patch)
2012-01-23 06:30 PST, Vsevolod Vlasov 		no flags Details | Formatted Diff | Diff
Patch (15.39 KB, patch)
2012-01-23 06:54 PST, Vsevolod Vlasov 		pfeldman: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-01-20 08:01:26 PST 
IndexedDBModel should keep track of requests sent to the backend.
Comment 1 Vsevolod Vlasov 2012-01-20 08:04:21 PST 
Otherwise after we send a request for a particular frame we can get a response when this frame was already detached/navigated.
Comment 2 Vsevolod Vlasov 2012-01-20 08:35:24 PST 
Created attachment 123326 [details]
Patch
Comment 3 Vsevolod Vlasov 2012-01-20 08:58:29 PST 
Created attachment 123333 [details]
Patch
Comment 4 Pavel Feldman 2012-01-23 01:08:00 PST 
Comment on attachment 123333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123333&action=review

> Source/WebCore/inspector/front-end/IndexedDBModel.js:255
>  WebInspector.IndexedDBDispatcher.prototype = {

We try to keep the logic either in the dispather or in the model. In your case, model is preferred. I'd suggest to make dispatcher a pure delegate.
Comment 5 Vsevolod Vlasov 2012-01-23 06:30:23 PST 
Created attachment 123548 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-01-23 06:54:05 PST 
Created attachment 123554 [details]
Patch
Comment 7 Pavel Feldman 2012-01-23 06:58:28 PST 
Comment on attachment 123554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123554&action=review

> Source/WebCore/inspector/front-end/IndexedDBModel.js:37
> +    this._indexedDBAgent = new WebInspector.IndexedDBAgentWrapper;

We use () upon constructions.

> Source/WebCore/inspector/front-end/IndexedDBModel.js:307
> +WebInspector.IndexedDBAgentWrapper.DatabasesForFrameRequest = function(frameId, callback)

IndexedDBRequestManager?
Comment 8 Vsevolod Vlasov 2012-01-23 07:17:24 PST 
Committed r105621: <http://trac.webkit.org/changeset/105621>