Bug 76704 - Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
Summary: Remove unneccesary canExecuteScripts check from v8 bindings, and correctly in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 05:55 PST by jochen
Modified: 2012-02-03 11:32 PST (History)
4 users (show)

See Also:

Attachments
Patch (5.75 KB, patch)
2012-01-20 05:56 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (7.81 KB, patch)
2012-02-02 17:03 PST, jochen 		no flags Details | Formatted Diff | Diff
Patch (7.73 KB, patch)
2012-02-03 06:16 PST, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-01-20 05:55:45 PST 
Remove unneccesary canExecuteScripts check from v8 bindings, and correctly indeicate when we're about to execute a script
Comment 1 jochen 2012-01-20 05:56:08 PST 
Created attachment 123299 [details]
Patch
Comment 2 jochen 2012-01-20 05:56:23 PST 
still WIP
Comment 3 WebKit Review Bot 2012-01-20 09:26:40 PST 
Comment on attachment 123299 [details]
Patch

Attachment 123299 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11312135

New failing tests:
editing/pasteboard/drag-image-in-about-blank-frame.html
Comment 4 jochen 2012-02-02 17:03:33 PST 
Created attachment 125212 [details]
Patch
Comment 5 WebKit Review Bot 2012-02-02 17:54:28 PST 
Comment on attachment 125212 [details]
Patch

Attachment 125212 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/11420043

New failing tests:
editing/pasteboard/drag-image-in-about-blank-frame.html
Comment 6 Adam Barth 2012-02-03 00:45:14 PST 
Comment on attachment 125212 [details]
Patch

This seems like a good patch.  What's the deal with the failing test?
Comment 7 jochen 2012-02-03 06:16:48 PST 
Created attachment 125315 [details]
Patch
Comment 8 jochen 2012-02-03 06:17:46 PST 
(In reply to comment #6)
> (From update of attachment 125212 [details])
> This seems like a good patch.  What's the deal with the failing test?

seems like the check in V8DOMWrapper.cpp was there for a reason.
Comment 9 WebKit Review Bot 2012-02-03 11:32:50 PST 
Comment on attachment 125315 [details]
Patch

Clearing flags on attachment: 125315

Committed r106680: <http://trac.webkit.org/changeset/106680>
Comment 10 WebKit Review Bot 2012-02-03 11:32:55 PST 
All reviewed patches have been landed.  Closing bug.