Bug 76691 - [GTK] Allow extra jhbuild modulesets
Summary: [GTK] Allow extra jhbuild modulesets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-20 02:36 PST by Philippe Normand
Modified: 2012-01-20 08:50 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.77 KB, patch)
2012-01-20 02:40 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (1.87 KB, patch)
2012-01-20 03:27 PST, Philippe Normand 		no flags Details | Formatted Diff | Diff
Patch (1.89 KB, patch)
2012-01-20 04:32 PST, Philippe Normand 		gustavo: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2012-01-20 02:36:20 PST 
It'd be nice if we could add new modulesets and modules easily using env variables.
My main use-case is to include my gst-0.11 moduleset :=)
Comment 1 Philippe Normand 2012-01-20 02:40:55 PST 
Created attachment 123277 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-01-20 03:16:39 PST 
Comment on attachment 123277 [details]
Patch

Attachment 123277 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/11297056
Comment 3 Philippe Normand 2012-01-20 03:27:16 PST 
Created attachment 123279 [details]
Patch
Comment 4 Gustavo Noronha (kov) 2012-01-20 04:19:50 PST 
Comment on attachment 123279 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review

This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you?

> Tools/gtk/jhbuildrc:26
> +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules')

s/module/moduleset/ for consistency would be good
Comment 5 Philippe Normand 2012-01-20 04:29:41 PST 
(In reply to comment #4)
> (From update of attachment 123279 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123279&action=review
> 
> This is a great idea IMO! I'm just wondering whether we should use some kind of namespace protection for our env variables. Maybe make them WebKitExtraModules (or WEBKIT_EXTRA_MODULES), etc. What say you?
> 

I say good idea indeed :)

> > Tools/gtk/jhbuildrc:26
> > +__module_file_uri = 'file://' + os.path.join(__gtk_tools_directory, 'jhbuild.modules')
> 
> s/module/moduleset/ for consistency would be good

Yup! Will send a new patch!
Comment 6 Philippe Normand 2012-01-20 04:32:07 PST 
Created attachment 123291 [details]
Patch
Comment 7 Gustavo Noronha (kov) 2012-01-20 07:23:17 PST 
Comment on attachment 123291 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123291&action=review

> Tools/ChangeLog:11
> +        * gtk/jhbuildrc: Extra modulesets and modules can be added in
> +        JHBuild using the EXTRA_MODULESETS and EXTRA_MODULES env variables
> +        respectively. Use comma-separated values. Example:
> +        EXTRA_MODULES=file:///path/to/module.set,file:///other/path.

LIES =) the variables changed names
Comment 8 Philippe Normand 2012-01-20 08:50:06 PST 
Committed r105519: <http://trac.webkit.org/changeset/105519>