Removed some regexp entry boilerplate code

[Geoffrey Garen]

Removed some regexp entry boilerplate code

[Geoffrey Garen]

Created attachment 123261 [details]
Patch

[Michael Saboff]

This changes seem fine to me.

[Darin Adler]

Comment on attachment 123261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123261&action=review

> Source/JavaScriptCore/runtime/RegExp.cpp:339
> +    ASSERT(startOffset >= 0);

Another approach might be to use the type unsigned instead of int.

> Source/JavaScriptCore/runtime/RegExp.cpp:340
> +    ASSERT(!s.isNull());

Clearly the check for null that was here before was unneeded. But the assertion also seems unneeded. The code seems like it would do just fine if passed a null string, and shouldn’t be so picky!

> Source/JavaScriptCore/runtime/RegExp.cpp:343
> +    ASSERT(m_state != ParseError);
>  
>      ASSERT(m_state != ParseError);

Oops, left this assertion in twice.

[Geoffrey Garen]

Created attachment 123351 [details]
Patch

[Geoffrey Garen]

Created attachment 123352 [details]
Patch

[Geoffrey Garen]

Created attachment 123357 [details]
Patch

[Geoffrey Garen]

Committed r105539: <http://trac.webkit.org/changeset/105539>

[Daniel Bates]

Comment on attachment 123357 [details]
Patch

Clearing review flag on patch to remove it from the review queue since it was already committed per comment 7.