RESOLVED DUPLICATE of bug 46761 76679
We shouldn't synchronously update styles on all documents after running script 
https://bugs.webkit.org/show_bug.cgi?id=76679
Summary We shouldn't synchronously update styles on all documents after running script
James Robinson
Reported 2012-01-19 18:03:26 PST
We shouldn't synchronously update styles on all documents after running script
Attachments
Patch (8.79 KB, patch)
2012-01-19 18:06 PST, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-01-19 18:06:38 PST
Created attachment 123232 [details] Patch
James Robinson
Comment 2 2012-01-19 18:10:10 PST
I believe this patch should be safe, and it passes nearly all layout tests, but a few tests have a diff that I can't quite explain. Roughly a half dozen editing tests have diffs that look like this: --- editing/selection/caret-rtl-expected.txt +++ editing/selection/caret-rtl-actual.txt @@ -14,4 +14,5 @@ RenderText {#text} at (0,0) size 38x19 text run at (0,0) width 38: "PASS" RenderBR {BR} at (38,0) size 0x19 + RenderText {#text} at (0,0) size 0x0 caret: position 7 of child 0 {#text} of child 3 {DIV} of body on this test there's a 0x0 RenderText in the DRT-generated dump. Similarly, on a small number of dumpAsText() tests there's an extra newline at the end of the text dump. Oddly enough if I call Document::updateStylesForAllDocuments() immediately before dumping the final tree these persist.
Simon Fraser (smfr)
Comment 3 2012-01-19 18:14:50 PST
Dup of bug 46761. Lots of discussion there about empty text nodes.
James Robinson
Comment 4 2012-01-19 18:27:04 PST
*** This bug has been marked as a duplicate of bug 46761 ***
Eric Seidel (no email)
Comment 5 2012-01-30 16:01:22 PST
Comment on attachment 123232 [details] Patch Cleared review? from attachment 123232 [details] so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).
Note You need to log in before you can comment on or make changes to this bug.