Bug 76679 - We shouldn't synchronously update styles on all documents after running script
Summary: We shouldn't synchronously update styles on all documents after running script
Status: RESOLVED DUPLICATE of bug 46761
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 18:03 PST by James Robinson
Modified: 2012-01-30 16:01 PST (History)
10 users (show)

See Also:

Attachments
Patch (8.79 KB, patch)
2012-01-19 18:06 PST, James Robinson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-01-19 18:03:26 PST 
We shouldn't synchronously update styles on all documents after running script
Comment 1 James Robinson 2012-01-19 18:06:38 PST 
Created attachment 123232 [details]
Patch
Comment 2 James Robinson 2012-01-19 18:10:10 PST 
I believe this patch should be safe, and it passes nearly all layout tests, but a few tests have a diff that I can't quite explain.  Roughly a half dozen editing tests have diffs that look like this:

--- editing/selection/caret-rtl-expected.txt 
+++ editing/selection/caret-rtl-actual.txt 
@@ -14,4 +14,5 @@
         RenderText {#text} at (0,0) size 38x19
           text run at (0,0) width 38: "PASS"
         RenderBR {BR} at (38,0) size 0x19
+        RenderText {#text} at (0,0) size 0x0
 caret: position 7 of child 0 {#text} of child 3 {DIV} of body

on this test there's a 0x0 RenderText in the DRT-generated dump. Similarly, on a small number of dumpAsText() tests there's an extra newline at the end of the text dump.  Oddly enough if I call Document::updateStylesForAllDocuments() immediately before dumping the final tree these persist.
Comment 3 Simon Fraser (smfr) 2012-01-19 18:14:50 PST 
Dup of bug 46761. Lots of discussion there about empty text nodes.
Comment 4 James Robinson 2012-01-19 18:27:04 PST 

*** This bug has been marked as a duplicate of bug 46761 ***
Comment 5 Eric Seidel (no email) 2012-01-30 16:01:22 PST 
Comment on attachment 123232 [details]
Patch

Cleared review? from attachment 123232 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).