Bug 76667 - Turn on CSS Filters on Windows
Summary: Turn on CSS Filters on Windows
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Marrin
Keywords: InRadar
Depends on: 77673
  Show dependency treegraph
Reported: 2012-01-19 15:02 PST by Chris Marrin
Modified: 2012-02-02 14:50 PST (History)
2 users (show)

See Also:

Patch (4.92 KB, patch)
2012-02-02 09:40 PST, Chris Marrin
adele: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Marrin 2012-01-19 15:02:49 PST
Need to turn on CSS Filters (software path) on Windows
Comment 1 Chris Marrin 2012-01-19 15:05:44 PST
InRadar <rdar://problem/10609286>
Comment 2 Chris Marrin 2012-02-02 09:40:36 PST
Created attachment 125149 [details]
Comment 3 Chris Marrin 2012-02-02 09:58:59 PST
Committed r106566: <http://trac.webkit.org/changeset/106566>
Comment 5 Andy Estes 2012-02-02 12:57:10 PST
(In reply to comment #4)
> This broke the Windows build:
> http://build.webkit.org/builders/Windows%20Debug%20%28Build%29/builds/45220/steps/compile-webkit/logs/stdio

Comment 6 Andy Estes 2012-02-02 13:13:00 PST
Rolled out in <http://trac.webkit.org/changeset/106586>. Reopening.
Comment 7 Andy Estes 2012-02-02 14:15:27 PST
The problem is that the build system (at least the Windows build system) isn't smart enough to re-process CSSPropertyNames.in when preprocessor macros change. I'm going to re-land Chris's patch with a whitespace-only change to CSSPropertyNames.in, which should force the bots to re-generate CSSPropertyNames.h.
Comment 8 Andy Estes 2012-02-02 14:50:54 PST
Committed r106593: <http://trac.webkit.org/changeset/106593>