Bug 76662 - DumpRenderTree and WebKitTestRunner should support --timeout option
Summary: DumpRenderTree and WebKitTestRunner should support --timeout option
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 78146
Blocks:
  Show dependency treegraph
 
Reported: 2012-01-19 13:44 PST by Ryosuke Niwa
Modified: 2013-04-09 18:01 PDT (History)
12 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-01-19 13:44:25 PST
As Dirk and I discussed on IRC, we should have --timeout <timeout> option in each port's DRT.

This will allow DRT to gracefully timeout instead of webkit.py detecting the timeout and restarting DRT.
Comment 1 Dirk Pranke 2012-01-19 13:47:46 PST
Note that this does not replace the timer in webkit.py; we still need that to protect against a failing DRT (as we see on Chromium, which doesn't have the timer in chromium.py; see bug 74039).

A partial motivation for this is that since the non-chromium DRTs have hard-coded watchdog timers, long --time-out-ms values don't work correctly. That's bad.

This will also allow us to clean up the no_timeout parameter added to the Driver interface in bug 76612.