Bug 76652 – CaseFoldingHash::hash() doesn't handle 8 bit strings directly

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

CaseFoldingHash::hash(StringImpl* str) should have a path for 8 bit strings.

[Michael Saboff]

Created attachment 123205 [details]
Patch

[Andreas Kling]

Comment on attachment 123205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review

r=me, just one little thing:

> Source/JavaScriptCore/wtf/text/StringHash.h:105
>              return hash(str->characters(), str->length());

You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters().

[Michael Saboff]

(In reply to comment #2)
> (From update of attachment 123205 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review
> 
> r=me, just one little thing:
> 
> > Source/JavaScriptCore/wtf/text/StringHash.h:105
> >              return hash(str->characters(), str->length());
> 
> You should switch this to characters16() to avoid the extra is8Bit() check in StringImpl::characters().

Thanks for catching that.  I'll make the change before checking in.

[Michael Saboff]

Committed r106260: <http://trac.webkit.org/changeset/106260>