Bug 76651 - stringProtoFuncReplace converts 8 bit strings to 16 bit during replacement
Summary: stringProtoFuncReplace converts 8 bit strings to 16 bit during replacement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 11:43 PST by Michael Saboff
Modified: 2012-01-30 10:52 PST (History)
0 users

See Also:

Attachments
Patch (5.31 KB, patch)
2012-01-19 15:04 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-01-19 11:43:16 PST 
stringProtoFuncReplace() ends up calling substituteBackRef() in the same file which converts 8 bit strings to 16 bit strings creating a 16 bit result.  This was found running the dromaeo tests.
Comment 1 Michael Saboff 2012-01-19 15:04:44 PST 
Created attachment 123204 [details]
Patch
Comment 2 Geoffrey Garen 2012-01-19 15:23:55 PST 
Comment on attachment 123204 [details]
Patch

r=me
Comment 3 Michael Saboff 2012-01-30 10:52:02 PST 
Committed r106257: <http://trac.webkit.org/changeset/106257>