WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
76650
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650
Summary
check-webkit-style whitespace/operators triggers on overloaded division operator
Emil A Eklund
Reported
2012-01-19 11:40:36 PST
+ inline float operator*(const float a, const AppUnit& b) Source/WebCore/platform/AppUnit.h:330: Missing spaces around / [whitespace/operators] [3] The whitespace/operators check triggers on declaration of overloaded operators. It should probably by modified to special case operators immediately preceded by the keyword operator. See
bug 76571
for an example.
Attachments
Patch
(2.30 KB, patch)
2012-01-23 15:45 PST
,
Emil A Eklund
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Emil A Eklund
Comment 1
2012-01-23 15:42:34 PST
This only happens for the division operator, all other ones seems fine.
Emil A Eklund
Comment 2
2012-01-23 15:45:23 PST
Created
attachment 123640
[details]
Patch
Emil A Eklund
Comment 3
2012-01-23 16:01:26 PST
Comment on
attachment 123640
[details]
Patch Clearing flags on attachment: 123640 Committed
r105652
: <
http://trac.webkit.org/changeset/105652
>
Emil A Eklund
Comment 4
2012-01-23 16:01:29 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug