Bug 76650 - check-webkit-style whitespace/operators triggers on overloaded division operator
Summary: check-webkit-style whitespace/operators triggers on overloaded division operator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Emil A Eklund
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 11:40 PST by Emil A Eklund
Modified: 2012-01-23 16:01 PST (History)
4 users (show)

See Also:

Attachments
Patch (2.30 KB, patch)
2012-01-23 15:45 PST, Emil A Eklund 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emil A Eklund 2012-01-19 11:40:36 PST 
+ inline float operator*(const float a, const AppUnit& b)
Source/WebCore/platform/AppUnit.h:330:  Missing spaces around /  [whitespace/operators] [3]

The whitespace/operators check triggers on declaration of overloaded operators. It should probably by modified to special case operators immediately preceded by the keyword operator.

See bug 76571 for an example.
Comment 1 Emil A Eklund 2012-01-23 15:42:34 PST 
This only happens for the division operator, all other ones seems fine.
Comment 2 Emil A Eklund 2012-01-23 15:45:23 PST 
Created attachment 123640 [details]
Patch
Comment 3 Emil A Eklund 2012-01-23 16:01:26 PST 
Comment on attachment 123640 [details]
Patch

Clearing flags on attachment: 123640

Committed r105652: <http://trac.webkit.org/changeset/105652>
Comment 4 Emil A Eklund 2012-01-23 16:01:29 PST 
All reviewed patches have been landed.  Closing bug.