Bug 76649 - Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
Summary: Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 11:39 PST by Michael Saboff
Modified: 2012-01-30 10:30 PST (History)
2 users (show)

See Also:

Attachments
Patch (5.12 KB, patch)
2012-01-19 14:52 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-01-19 11:39:12 PST 
Dromaeo tests cause parseSimpleLengthValue() on 8 bit strings to be converted to 16 bit strings.  This routine should have an 8 bit path.
Comment 1 Michael Saboff 2012-01-19 14:52:55 PST 
Created attachment 123203 [details]
Patch

Added 8 bit path.
Comment 2 Geoffrey Garen 2012-01-19 15:56:41 PST 
Comment on attachment 123203 [details]
Patch

For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary.
Comment 3 Michael Saboff 2012-01-30 10:28:19 PST 
(In reply to comment #2)
> (From update of attachment 123203 [details])
> For simplicity, can this function just use StringImpl::operator[]? It only does three derefs of the string, so using the characters pointer may not be necessary.

We still need the appropriate character pointer to call charactersToDouble().
Comment 4 Michael Saboff 2012-01-30 10:30:49 PST 
Committed r106254: <http://trac.webkit.org/changeset/106254>