Bug 76645 - Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
Summary: Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-19 11:14 PST by Michael Saboff
Modified: 2012-01-26 11:24 PST (History)
0 users

See Also:

Attachments
Patch (5.80 KB, patch)
2012-01-19 11:58 PST, Michael Saboff 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-01-19 11:14:02 PST 
Many of the dromaeo tests end up using StringImpl::find() and ::reverseFind() including the IgnoreCase varieties.  These methods don't have 8 bit string paths.
Comment 1 Michael Saboff 2012-01-19 11:58:26 PST 
Created attachment 123163 [details]
Patch

This appears to be neutral to slightly positive to sun spider  and v8 performance.
Comment 2 Geoffrey Garen 2012-01-19 15:59:10 PST 
Comment on attachment 123163 [details]
Patch

I think you should factor out the shared hash-search code into a static helper function template, to avoid code duplication.
Comment 3 Michael Saboff 2012-01-26 11:24:11 PST 
Committed r106019: <http://trac.webkit.org/changeset/106019>