RESOLVED FIXED 76645
Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions 
https://bugs.webkit.org/show_bug.cgi?id=76645
Summary Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions
Michael Saboff
Reported 2012-01-19 11:14:02 PST
Many of the dromaeo tests end up using StringImpl::find() and ::reverseFind() including the IgnoreCase varieties. These methods don't have 8 bit string paths.
Attachments
Patch (5.80 KB, patch)
2012-01-19 11:58 PST, Michael Saboff 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2012-01-19 11:58:26 PST
Created attachment 123163 [details] Patch This appears to be neutral to slightly positive to sun spider and v8 performance.
Geoffrey Garen
Comment 2 2012-01-19 15:59:10 PST
Comment on attachment 123163 [details] Patch I think you should factor out the shared hash-search code into a static helper function template, to avoid code duplication.
Michael Saboff
Comment 3 2012-01-26 11:24:11 PST
Committed r106019: <http://trac.webkit.org/changeset/106019>
Note You need to log in before you can comment on or make changes to this bug.